Skip to content

bugfix when use "Time Series - Line Chart" and "Big Number with Trendline" on dashboard#5035

Closed
yamoe wants to merge 1 commit intoapache:masterfrom
yamoe:master
Closed

bugfix when use "Time Series - Line Chart" and "Big Number with Trendline" on dashboard#5035
yamoe wants to merge 1 commit intoapache:masterfrom
yamoe:master

Conversation

@yamoe
Copy link

@yamoe yamoe commented May 18, 2018 •
edited
Loading

when i use "Time Series - Line Chart" and "Big Number with Trendline" on dashboard.
just show a blank page in grid-container.

error message in web console log :

Dashboard.jsx:150 Uncaught TypeError: Cannot read property 'concat' of undefined
    at Dashboard.getFormDataExtra (Dashboard.jsx:150)
    at GridLayout.jsx:151
    at Array.map (<anonymous>)
    at GridLayout.render (GridLayout.jsx:134)
    at ReactCompositeComponent.js:793
    at measureLifeCyclePerf (ReactCompositeComponent.js:73)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js:792)
    at ReactCompositeComponentWrapper._renderValidatedComponent (ReactCompositeComponent.js:819)
    at ReactCompositeComponentWrapper.performInitialMount (ReactCompositeComponent.js:359)
    at ReactCompositeComponentWrapper.mountComponent (ReactCompositeComponent.js:255)

because of formDataExtra.extra_filters and formDataExtra.filters is "undefined"
at incubator-superset/superset/assets/src/dashboard/components/Dashboard.jsx (about 145 lines)

@mistercrunch
Copy link
Member

mistercrunch commented May 18, 2018

Which version is this? Does it happen on master ?

@yamoe
Copy link
Author

yamoe commented May 20, 2018

yes. it's happened master HEAD version.

@yamoe
Copy link
Author

yamoe commented May 25, 2018

this bug has disappeared and i close it.
thx

@yamoe yamoe closed this May 25, 2018
@matrix-compute matrix-compute mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yamoe @mistercrunch